Re: pgsql: Avoid doing catalog lookups in postgres_fdw's conversion_error_c

Hi!

> 6 июля 2021 г., в 19:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> написал(а):
>
> Avoid doing catalog lookups in postgres_fdw's conversion_error_callback.

I'm observing a related coredump in

+ ForeignScan *fsplan = castNode(ForeignScan, fsstate->ss.ps.plan);

#0 conversion_error_callback (arg=0x7ffe445cdf40) at ./build/../contrib/postgres_fdw/postgres_fdw.c:6455
#1 0x000055a51eb108c7 in errfinish (dummy=dummy(at)entry=0) at ./build/../src/backend/utils/error/elog.c:435
#2 0x000055a51eae07c5 in varchar_input (
s=0x55a520b54c24 "--skipped user data--"..., len=516, atttypmod=<optimized out>) at ./build/../src/backend/utils/adt/varchar.c:471
#3 0x000055a51eb166f6 in InputFunctionCall (flinfo=0x55a520b26dc8,
str=0x55a520b54c24 "--skipped user data--"..., typioparam=<optimized out>, typmod=<optimized out>) at ./build/../src/backend/utils/fmgr/fmgr.c:1548
#4 0x00007f373d0d06b9 in make_tuple_from_result_row (res=res(at)entry=0x55a5208145e0, row=row(at)entry=92, rel=<optimized out>, attinmeta=0x55a520a148b8, retrieved_attrs=<optimized out>,
fsstate=fsstate(at)entry=0x0, temp_context=0x55a520893150) at ./build/../contrib/postgres_fdw/postgres_fdw.c:6377
#5 0x00007f373d0d0c3e in analyze_row_processor (astate=0x7ffe445ce060, row=92, res=0x55a5208145e0) at ./build/../contrib/postgres_fdw/postgres_fdw.c:4664
#6 postgresAcquireSampleRowsFunc (relation=relation(at)entry=0x55a520a8e278, elevel=elevel(at)entry=13, rows=rows(at)entry=0x55a520c43c38, targrows=targrows(at)entry=300000,
totalrows=totalrows(at)entry=0x7ffe445ce348, totaldeadrows=totaldeadrows(at)entry=0x7ffe445ce350) at ./build/../contrib/postgres_fdw/postgres_fdw.c:4566
#7 0x000055a51e7ffdad in do_analyze_rel (onerel=onerel(at)entry=0x55a520a8e278, params=params(at)entry=0x7ffe445ce7c0, va_cols=va_cols(at)entry=0x0,
acquirefunc=0x7f373d0d0830 <postgresAcquireSampleRowsFunc>, relpages=272774, inh=inh(at)entry=false, in_outer_xact=true, elevel=13) at ./build/../src/backend/commands/analyze.c:502
#8 0x000055a51e8013d4 in analyze_rel (relid=<optimized out>, relation=<optimized out>, params=params(at)entry=0x7ffe445ce7c0, va_cols=0x0, in_outer_xact=<optimized out>,
bstrategy=<optimized out>) at ./build/../src/backend/commands/analyze.c:260
#9 0x000055a51e87660b in vacuum (relations=0x55a520845e10, params=params(at)entry=0x7ffe445ce7c0, bstrategy=<optimized out>, bstrategy(at)entry=0x0, isTopLevel=isTopLevel(at)entry=true)
at ./build/../src/backend/commands/vacuum.c:413
#10 0x000055a51e876c59 in ExecVacuum (pstate=pstate(at)entry=0x55a52085d660, vacstmt=vacstmt(at)entry=0x55a5209789e0, isTopLevel=isTopLevel(at)entry=true)
at ./build/../src/backend/commands/vacuum.c:199

If this is known issue, sorry for the noise.

Thanks!

Best regards, Andrey Borodin.