pg_ctl -o option dumps core when processing postmaster arguments...

From: Sean Chittenden <seanc(at)FreeBSD(dot)org>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: pg_ctl -o option dumps core when processing postmaster arguments...
Date: 2004-07-26 19:25:18
Message-ID: 08611B16-DF36-11D8-B252-000A95C705DC@chittenden.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The attached space adds '\0' as a whitespace character and prevents
pg_ctl from running out of bounds when processing arguments for -o. I
don't think this ever worked, at least on Mac, but I suspect every
platform suffered from this bug.

% gdb ./bin/pg_ctl
GNU gdb 5.3-20030128 (Apple version gdb-309) (Thu Dec 4 15:41:30 GMT
2003)
This GDB was configured as "powerpc-apple-darwin".
Reading symbols for shared libraries ........ done
(gdb) set arg -w -o -F start
(gdb) run
Starting program: /usr/local/pgsql/bin/pg_ctl -w -o -F start
Reading symbols for shared libraries ++.. done
waiting for postmaster to start...
Program received signal EXC_BAD_ACCESS, Could not access memory.
test_postmaster_connection () at pg_ctl.c:363
363 p++;
(gdb) bt
#0 test_postmaster_connection () at pg_ctl.c:363
#1 0x00003594 in do_start () at pg_ctl.c:539
#2 0x00003594 in do_start () at pg_ctl.c:539
#3 0x00004874 in main (argc=-1610604968, argv=0x0) at pg_ctl.c:1360
(gdb) p *p
$1 = 0 '\0'

-sc

Attachment Content-Type Size
patch.txt text/plain 570 bytes

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-07-26 19:40:40 Re: win32 version info
Previous Message Magnus Hagander 2004-07-26 18:51:22 Re: win32 version info