Re: SQL:2011 application time

On 1/2/25 17:47, Paul Jungwirth wrote:
> On 12/10/24 06:40, Peter Eisentraut wrote:
>> On 07.12.24 20:29, Paul Jungwirth wrote:
>>> These five patches all look good to me.
>>>
>>> Note that my tests already include a section for REPLICA IDENTITY FULL, which passed. But the
>>> subscriber was using a SeqScan to look up tuples to update.
>>>
>>> Here are the steps (mostly just because it was confusing for me at first): First in
>>> FindUsableIndexForReplicaIdentityFull, we would call IsIndexUsableForReplicaIdentityFull, get
>>> back false, and decide there was no index to use. Then in FindReplTupleInLocalRel, localidxoid
>>> was 0, so we woudln't call IsIndexUsableForReplicaIdentityFull at all.
>>>
>>> After applying the five patches, I can see that we choose the index and call
>>> IsIndexUsableForReplicaIdentityFull from both sites. This should make applying changes a lot faster.
>>
>> I have committed these.  I will continue with reviewing v45-0002 and following now.
>
> Here is a rebase for the remaining patches. There are some small changes, but almost all the work
> was fixing the final PERIOD patch (mostly to work with the new cataloged NOT NULL code).

These updates fix a problem in the unaccent contrib module. When I added a new parameter to
get_func_namespace, I changed a call there. Then I when took out that parameter, I didn't update the
extension again. Otherwise these are the same as the v46 patches.

Yours,

--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com