| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add two missing tests in 035_standby_logical_decoding.pl |
| Date: | 2023-05-03 12:16:54 |
| Message-ID: | 083247ee-2366-dd53-803b-0582faa6a52a@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 5/3/23 12:29 PM, Amit Kapila wrote:
> On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>
>>
>> As per your suggestion, changing the insert ordering (like in V8 attached) makes it now work on the failing environment too.
>>
>
> I think it is better to use wait_for_replay_catchup() to wait for
> standby to catch up.
Oh right, that's a discussion we already had in [1], I should have thought about it.
> I have changed that and a comment in the
> attached. I'll push this tomorrow unless there are further comments.
>
LGTM, thanks!
[1]: https://www.postgresql.org/message-id/acbac69e-9ae8-c546-3216-8ecb38e7a93d%40gmail.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2023-05-03 13:11:33 | Re: pg_stat_io for the startup process |
| Previous Message | Alvaro Herrera | 2023-05-03 10:40:34 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |