Re: PATCH: Make pg_stop_backup() archive wait optional

Hi Robert,

On 3/6/17 12:48 PM, Robert Haas wrote:
> On Sat, Mar 4, 2017 at 9:12 AM, David Steele <david(at)pgmasters(dot)net> wrote:
>> Yes, that makes sense. Attached are two patches as requested:
>>
>> 01 - Just marks pg_stop_backup() variants as parallel restricted
>> 02 - Add the wait_for_archive param to pg_stop_backup().
>>
>> These apply cleanly on 272adf4.
>
> Committed 01.

Thanks!

> Nobody's offered an opinion about 02 yet, so I'm not
> going to commit that, but one minor nitpick:
>
> + WAL to be archived. This behavior is only useful for backup
> + software which independently monitors WAL archiving, otherwise WAL
> + required to make the backup consistent might be missing and make the backup
>
> I think this should really say "...which independently monitors WAL
> archiving. Otherwise, WAL..."

The attached patch udpates the docs per your suggestion and has been
rebased on master at d69fae2.

Thanks,
--
-David
david(at)pgmasters(dot)net