Re: [bug fix] psql's \conninfo reports incorrect destination on Windows

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] psql's \conninfo reports incorrect destination on Windows
Date: 2014-01-24 13:34:41
Message-ID: 078B32DA99374C1696E2B13BA182AD08@maumau
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
> On Fri, Jan 24, 2014 at 9:00 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
>> OTOH, regarding PQhost(), I think we had better take my patch.
>> connectOptions2() computes and set derived values to PGconn, so that
>> PGconn's members have values which are actually used for connection. To
>> follow that rule, PGconn->pghost may as well have "localhost" on machines
>> without UNIX domain sockets.
>
> I'm not sure if we should follow that rule. As far as I read the libpq
> code,
> at least connectFailureMessage() and connectDBStart() do the same things
> as PQhost() does now.

Yes, I found them ugly, too. Maybe we can refactor them as a separate
patch.

Regards
MauMau

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2014-01-24 14:01:25 Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance
Previous Message MauMau 2014-01-24 13:31:17 Re: [9.3 bug] disk space in pg_xlog increases during archive recovery