Re: CFbot failed on Windows platform

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: byavuz81(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: CFbot failed on Windows platform
Date: 2024-07-11 16:28:28
Message-ID: 075957ae-34d7-4153-8dc5-df55ab35a23e@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-07-11 Th 9:50 AM, Tom Lane wrote:
> Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
>>> I think It is related to the '628c1d1f2c' commit. This commit changed
>>> the output of the regress test in Windows.
>> Yeah, it seems that explains. I see few buildfarm window animals
>> complain too.
> I think that the contents of
> src/test/regress/expected/collate.windows.win1252.out are actually
> wrong, and we'd not noticed because it was only checked with diff -w.
> psql does put an extra trailing space in some lines of table output,
> but that space isn't there in collate.windows.win1252.out.
>
>

Yeah, makes sense I will produce an updated output file and then
re-enable --strip-trailing-cr (after a full test run).

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2024-07-11 16:29:02 Re: POC, WIP: OR-clause support for indexes
Previous Message Alena Rybakina 2024-07-11 16:17:42 Re: POC, WIP: OR-clause support for indexes