Re: removing unnecessary get_att*() lsyscache functions

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: removing unnecessary get_att*() lsyscache functions
Date: 2018-10-23 12:50:25
Message-ID: 072e1f52-b3d9-bf01-6a37-3d89aabc3fd3@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23/10/2018 02:11, Michael Paquier wrote:
> On Mon, Oct 22, 2018 at 07:12:28PM +0200, Peter Eisentraut wrote:
>> OK, slightly reworked version attached.
>
> + attTup = (Form_pg_attribute) GETSTRUCT(tuple);
> attnum = ((Form_pg_attribute) GETSTRUCT(tuple))->attnum;
>
> No need to call twice GETSTRUCT here.. The rest looks fine.

Fixed that, and committed, thanks.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-10-23 13:09:54 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Erik Rijkers 2018-10-23 12:50:18 Re: [HACKERS] proposal: schema variables