Re: Foreign tables don't enforce the partition constraint

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Foreign tables don't enforce the partition constraint
Date: 2017-04-03 07:44:51
Message-ID: 071086d7-6462-f0e7-54ca-b633062e317c@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ashutosh,

On 2017/04/03 15:49, Ashutosh Bapat wrote:
>>> Similarly, a partition constraint
>>> should also be enforced at the foreign server. Probably we should
>>> update documentation of create foreign table to mention this.
>>
>> That is a good idea.
>>
>> Here's the patch.

Thanks for creating the patch.

+ Constraints and partition bounds on foreign tables (such as

We use "partition constraint" instead of "partition bounds" to mean the
implicit constraint of a partition (there are a few instances of that in
the documentation). So, perhaps this could be written as: Constraints
(both the user-defined constraints such as <literal>CHECK</>
or <literal>NOT NULL</> clauses and the partition constraint) are not
enforced by the core <productname>PostgreSQL</> system, ...

And once we've mentioned that a constraint means one of these things, we
need not repeat "partition bounds/constraints" in the subsequent
paragraphs. If you agree, attached is the updated patch.

> I am not able to build documents on my laptop because of
> recent changes in d63762452434a3a046e8c7d130d5a77c594176e4. So, I was not
> able to check whether the patch builds or not. But I am hoping it builds
> well.

By the way, docs do build fine despite the error you see.

Thanks,
Amit

Attachment Content-Type Size
cft_doc_change-v2.patch text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2017-04-03 08:24:09 Re: Statement timeout behavior in extended queries
Previous Message Fabien COELHO 2017-04-03 07:43:39 Re: Variable substitution in psql backtick expansion