| From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
| Date: | 2018-12-26 05:05:19 |
| Message-ID: | 063eee37-47c2-cd96-d4fd-e742f933e59d@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/12/25 14:27, Michael Paquier wrote:
> On Tue, Dec 25, 2018 at 10:56:04AM +0900, Tatsuro Yamada wrote:
>> Hmm... Okey, I agree. Why I implemented the exotic part of the
>> feature is that it is for user-friendly. However, I suppose that
>> user know the syntax because the syntax is used by an expert user.
>
> Thanks, I have committed this one after making the logic to ignore
> column numbers a bit smarter, one problem being that "ALTER INDEX foo
> ALTER COLUMN" would try to suggest SET STATISTICS directly, which is
> incorrect. Instead I have tweaked the completion so as COLUMN is
> added after "ALTER INDEX foo ALTER". This could be completed later
> with the column numbers, in a way similar to what ALTER TABLE does.
> --
> Michael
Thanks for taking your time! :)
Cheers!
Tatsuro Yamada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2018-12-26 05:05:26 | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
| Previous Message | Michael Paquier | 2018-12-26 04:50:52 | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |