| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Review for GetWALAvailability() |
| Date: | 2020-06-18 01:29:27 |
| Message-ID: | 06307e6d-6c5a-d987-2a76-b68a2d8dff8a@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/06/18 3:04, Alvaro Herrera wrote:
> I think passing the slot name when the slot is also passed is useless
> and wasteful; it'd be better to pass NULL for the name and ignore the
> strcmp() in that case -- in fact I suggest to forbid passing both name
> and slot. (Any failure there would risk raising an error during
> checkpoint, which is undesirable.)
Sounds reasonable.
> So I propose the following tweaks to your patch, and otherwise +1.
Thanks for the patch! It looks good to me.
Barring any objections, I will commit the patches in the master and
v13 branches later.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-06-18 01:42:00 | Re: pg_regress cleans up tablespace twice. |
| Previous Message | Melanie Plageman | 2020-06-18 01:21:58 | Re: Improve planner cost estimations for alternative subplans |