Re: [PATCH] Clear up perlcritic 'missing return' warning

On 05/23/2018 02:00 PM, Andrew Dunstan wrote:
> On Wed, May 23, 2018 at 1:45 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> On 2018-May-23, Andrew Dunstan wrote:
>>
>>> And yes, the idea is that if we do this then we adopt a perlcritic
>>> policy that calls it out when we forget.
>> If we can have a buildfarm animal that runs perlcritic that starts green
>> (and turns yellow with any new critique), with a config that's also part
>> of our tree, so we can easily change it as we see fit, it should be
>> good.
>>
>
> Should be completely trivial to do. We already have the core
> infrastructure - I added it a week or two ago.
>

Not quite trivial but it's done - see
<https://github.com/PGBuildFarm/client-code/commit/92f94ba7df8adbcbdb08f0138d8b5e686611ba1f>.

crake is now set up to run this - see
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2018-05-26%2014%3A32%3A19&stg=perl-check>

So, are there any other objections?

The patch Mike supplied doesn't give us a clean run (at least on the
machine I tested on), since it turns down the severity level to 4 but
leaves some items unfixed. I propose to enable this policy at level 5
for now, and then remove that when we can go down to level 4 cleanly,
and use its default setting at that stage.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services