| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-08-11 23:23:52 |
| Message-ID: | 0545F7B3-70C0-4DE8-8C85-EAFE6113B7EE@amazon.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 8/9/21, 8:43 PM, "Andres Freund" <andres(at)anarazel(dot)de> wrote:
> I don't like putting this into PostmasterMain(). Either BootstrapMain()
> (specifically checker mode) or GucInfoMain() seem like better places.
I think BootstrapModeMain() makes the most sense. It fits in nicely
with the --check logic that's already there. With v3, the following
command can be used to retrieve the amount of shared memory required.
postgres --output-shmem -D dir
While testing this new option, I noticed that you can achieve similar
results today with the following command, although this one will
actually try to create the shared memory, too.
postgres --check -D dir -c log_min_messages=debug3 2> >(grep IpcMemoryCreate)
IMO the new option is still handy, but I can see the argument that it
might not be necessary.
> That seems like an ugly API to me. Why don't we split the size
> determination and shmem creation functions into two?
I did it this way in v3.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-introduce-option-for-retreiving-shmem-size.patch | application/octet-stream | 10.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shrikant Bhende | 2021-08-13 12:23:39 | Join for the parent table will not leverage the index scan |
| Previous Message | otar shavadze | 2021-08-10 14:01:49 | Index usage statistic for last X hours |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-08-11 23:25:10 | Re: 2021-08-12 release announcement draft |
| Previous Message | Tomas Vondra | 2021-08-11 23:06:57 | Re: Use extended statistics to estimate (Var op Var) clauses |