Re: pgindent vs variable declaration across multiple lines

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent vs variable declaration across multiple lines
Date: 2023-01-24 15:20:30
Message-ID: 04fac9c4-d3a9-b563-f197-fa554e87c362@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-01-22 Su 17:34, Tom Lane wrote:
> I've also attached a diff
> representing the delta between what current pg_bsd_indent wants to do
> to HEAD and what this would do. All the changes it wants to make look
> good, although I can't say whether there are other places it's failing
> to change that we'd like it to.
>
>

Changes look good. There are a handful of places where I think the code
would be slightly more readable if a leading typecast were moved to the
second line.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-24 15:30:42 Re: Making Vars outer-join aware
Previous Message Tom Lane 2023-01-24 15:13:23 Re: Improve GetConfigOptionValues function