Re: Correction of how to use TimeZone by ControlFile(xlog.c)

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Magnus Hagander" <magnus(at)hagander(dot)net>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Date: 2007-08-04 14:47:33
Message-ID: 046801c7d6a6$64728350$0d01a8c0@yourc3ftrhkaod
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi Tom-san.

My it looks very great.!!!
I was operating in the seen last night patch.....
Naturally, your thing is more great.

Thank you very much!:-)

Regards,
Hiroshi Saito

From: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>

> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Tom's idea of a log_timezone seems to make sense.
>
> Here's a preliminary patch for this --- no docs yet, but code is all
> there. Seems to work OK. The patch is larger than it'd really have to
> be because I chose to rename global_timezone to session_timezone;
> I thought it'd be confusing to have something called "global_timezone"
> that actually has a narrower scope than "log_timezone".
>
> This wouldn't do for backpatching of course. My inclination for a
> backpatch is to just take %Z out of the strftime formats for Windows,
> as we did in several places already.
>
> Comments?
>
> regards, tom lane
>
>

--------------------------------------------------------------------------------

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
>

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Decibel! 2007-08-04 17:24:51 Re: Repair cosmetic damage (done by pg_indent?)
Previous Message Andrew Dunstan 2007-08-04 01:26:22 Re: COPYable logs