Re: client-side fsync() error handling

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: client-side fsync() error handling
Date: 2020-02-13 09:02:31
Message-ID: 0412a2fb-cbde-08c6-9ff2-cfab5c27a3b8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-02-12 06:28, Michael Paquier wrote:
> Now, don't we need to care about durable_rename() and make the
> panic-like failure an optional choice? From what I can see, this
> routine is used now in the backend for pg_basebackup to rename
> temporary history files or partial WAL segments.

durable_rename() calls fsync_fname(), so it would be covered by this
change. The other file access calls in there can be handled by normal
error handling, I think. Is there any specific scenario you have in mind?

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-02-13 09:11:07 Re: Exposure related to GUC value of ssl_passphrase_command
Previous Message Peter Eisentraut 2020-02-13 08:56:38 backend type in log_line_prefix?