Re: Passing connection string to pg_basebackup

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Heikki Linnakangas'" <hlinnakangas(at)vmware(dot)com>
Cc: "'Boszormenyi Zoltan'" <zb(at)cybertec(dot)at>, "'Hari Babu'" <haribabu(dot)kommi(at)huawei(dot)com>, "'Fujii Masao'" <masao(dot)fujii(at)gmail(dot)com>, <pgsql-hackers(at)postgresql(dot)org>, "'Magnus Hagander'" <magnus(at)hagander(dot)net>
Subject: Re: Passing connection string to pg_basebackup
Date: 2013-01-18 11:41:36
Message-ID: 03e201cdf570$c67c9c90$5375d5b0$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Friday, January 18, 2013 3:46 PM Heikki Linnakangas wrote:
> On 18.01.2013 08:50, Amit Kapila wrote:
> > I think currently user has no way to specify TCP keepalive settings
> from
> > pg_basebackup, please let me know if there is any such existing way?
>
> I was going to say you can just use "keepalives_idle=30" in the
> connection string. But there's no way to pass a connection string to
> pg_basebackup on the command line! The usual way to pass a connection
> string is to pass it as the database name, and PQconnect will expand
> it,
> but that doesn't work with pg_basebackup because it hardcodes the
> database name as "replication". D'oh.
>
> You could still use environment variables and a service file to do it,
> but it's certainly more cumbersome. It clearly should be possible to
> pass a full connection string to pg_basebackup, that's an obvious
> oversight.

So to solve this problem below can be done:
1. Support connection string in pg_basebackup and mention keepalives or
connection_timeout
2. Support recv_timeout separately to provide a way to users who are not
comfortable tcp keepalives

a. 1 can be done alone
b. 2 can be done alone
c. both 1 and 2.

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Heikki Linnakangas 2013-01-18 12:05:05 Re: Passing connection string to pg_basebackup
Previous Message Tsunezumi 2013-01-18 11:26:57 Re: BUG #7814: Rotation of the log is not carried out.

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-01-18 11:57:54 More subtle issues with cascading replication over timeline switches
Previous Message Craig Ringer 2013-01-18 11:34:55 Re: WIP patch for hint bit i/o mitigation