Re: Detect buffer underflow in get_th()

From: Alexander Kuznetsov <kuznetsovam(at)altlinux(dot)org>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: nickel(at)altlinux(dot)org, egori(at)altlinux(dot)org
Subject: Re: Detect buffer underflow in get_th()
Date: 2024-09-24 14:52:32
Message-ID: 03df4973-3595-4078-a075-636bbb121f61@altlinux.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

is there anything else we can help with or discuss in order to apply this fix?

24.07.2024 18:53, Alexander Kuznetsov пишет:
>
> 24.07.2024 18:39, Peter Eisentraut wrote:
>> If it can't happen in practice, maybe an assertion would be enough?
>>
>
> In practice, the function should not receive non-numeric strings either; however, since there is an exception in place for such cases, I thought it would be good to add a check for zero-length input in a similar manner.
>
> But of course it's open for discussion and team decision whether this should be addressed as an assertion or handled differently.
>

--
Best regards,
Alexander Kuznetsov

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2024-09-24 15:14:42 Re: pgsql: Improve default and empty privilege outputs in psql.
Previous Message Alexander Kuznetsov 2024-09-24 14:50:59 Re: Possible null pointer dereference in afterTriggerAddEvent()