Re: pgsql: Replace BackendIds with 0-based ProcNumbers

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Replace BackendIds with 0-based ProcNumbers
Date: 2024-07-15 08:13:16
Message-ID: 03d4d128-c27d-4b78-b0c1-24a405a60bd2@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 09/07/2024 21:10, Thomas Munro wrote:
> --- a/src/backend/libpq/pqmq.c
> +++ b/src/backend/libpq/pqmq.c
> @@ -26,7 +26,7 @@
> static shm_mq_handle *pq_mq_handle;
> static bool pq_mq_busy = false;
> static pid_t pq_mq_parallel_leader_pid = 0;
> -static pid_t pq_mq_parallel_leader_backend_id = InvalidBackendId;
> +static pid_t pq_mq_parallel_leader_proc_number = INVALID_PROC_NUMBER;
>
> I guess it was a historical mistake that this variable of type pid_t
> instead of BackendId, but now it should be ProcNumber?

Yep, fixed thanks!

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2024-07-15 09:50:51 pgsql: Run LLVM verify pass on IR in assert builds.
Previous Message Heikki Linnakangas 2024-07-15 08:13:11 pgsql: Use correct type for pq_mq_parallel_leader_proc_number variable