| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Sutou Kouhei <kou(at)clear-code(dot)com> |
| Cc: | andres(at)anarazel(dot)de, tristan(at)neon(dot)tech, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: meson: Specify -Wformat as a common warning flag for extensions |
| Date: | 2024-06-07 07:44:26 |
| Message-ID: | 03ccee7f-527c-4298-9226-5fa79df26931@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29.05.24 08:47, Sutou Kouhei wrote:
> In <4707d4ed-f268-43c0-b4dd-cdbc7520f508(at)eisentraut(dot)org>
> "Re: meson: Specify -Wformat as a common warning flag for extensions" on Tue, 28 May 2024 23:31:05 -0700,
> Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
>> On 07.04.24 18:01, Sutou Kouhei wrote:
>>> +# We don't have "warning_level == 3" and "warning_level ==
>>> +# 'everything'" here because we don't use these warning levels.
>>> +if warning_level == '1'
>>> + common_builtin_flags += ['-Wall']
>>> +elif warning_level == '2'
>>> + common_builtin_flags += ['-Wall', '-Wextra']
>>> +endif
>>
>> I would trim this even further and always export just '-Wall'. The
>> other options aren't really something we support.
>
> OK. How about the v6 patch? It always uses '-Wall'.
I have committed this. Thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-06-07 08:05:43 | Re: Assert in heapgettup_pagemode() fails due to underlying buffer change |
| Previous Message | Dilip Kumar | 2024-06-07 06:46:30 | Re: Vacuum statistics |