Re: [PATCH] two-arg current_setting() with fallback

From: David Christensen <david(at)endpoint(dot)com>
To: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] two-arg current_setting() with fallback
Date: 2015-06-16 18:25:18
Message-ID: 035424DB-2622-4B5B-B4B7-88E2CE02C778@endpoint.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Date: Thu, 4 Jun 2015 13:55:52 +0530
> From: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
> To: david(dot)g(dot)johnston(at)gmail(dot)com
> Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
> Subject: Re: [PATCH] two-arg current_setting() with fallback
> Message-ID: <CAM2+6=VsTg=pAEdq6ioKpoLx7yapE9cs3UvFbNV310Ur7UpqhQ(at)mail(dot)gmail(dot)com>

> Hi,
>
> Attached patch which fixes my review comments.
>
> Since code changes were good, just fixed reported cosmetic changes.
>
> David, can you please cross check?

Hi Jeevan,

I’m just on the digest list, and it looks like I didn’t get copied on your response, so missed it until now.

Thanks for the review; I reviewed the changes you made and it looks good.

Regards,

David
--
David Christensen
PostgreSQL Team Manager
End Point Corporation
david(at)endpoint(dot)com
785-727-1171

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-06-16 18:58:44 Re: [GENERAL] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1
Previous Message Alvaro Herrera 2015-06-16 17:47:50 Re: [HACKERS] 9.4.1 -> 9.4.2 problem: could not access status of transaction 1