| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pgbench tests vs Windows |
| Date: | 2019-07-23 22:25:34 |
| Message-ID: | 0321952c-122a-4653-104d-c3c00410e4d5@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In commit ed8a7c6fcf9 we added some extra tests to pgbench, including
this snippet:
\setshell two\
expr \
1 + :one
Unfortunately, this isn't portable, as I've just discovered at the cost
of quite a bit of time. In particular, you can't assume expr is present
and in the path on Windows. The Windows equivalent would be something like:
\setshell two\
@set /a c = 1 + :one && echo %c%
I propose to prepare a patch along these lines. Alternatively we could
just drop it - I don't think the test matters all that hugely.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-07-23 22:32:50 | Re: range_agg |
| Previous Message | Simon Riggs | 2019-07-23 22:16:35 | Re: pgbench - allow to create partitioned tables |