| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server? |
| Date: | 2021-11-22 02:55:25 |
| Message-ID: | 0317edf0-6746-ddad-cab1-649f8302b502@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/11/20 1:38, Bharath Rupireddy wrote:
> It reports "remote SQL command: (cancel request)" which isn't a sql
> query, but it looks okay to me as we report (cancel request). The
> pgfdw_get_cleanup_result_v1 patch LGTM.
BTW, we can hide the message "remote SQL command: .." in cancel request case,
but which would make the debug and troubleshooting harder. So I decided to
use the string "(cancel request)" as SQL command string. Probably what string
should be used as SQL command might be debatable.
> I think we can discuss this refactoring patch separately. Thoughts?
Yes! I will consider again if it's worth doing the refactoring,
if yes, I will start new thread for the discussion for that.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2021-11-22 03:23:42 | Re: A spot of redundant initialization of brin memtuple |
| Previous Message | Fujii Masao | 2021-11-22 02:47:03 | Re: issue in pgfdw_report_error()? |