Re: Server instrumentation patch

From: "Michael Paesold" <mpaesold(at)gmx(dot)at>
To: "Andreas Pflug" <pgadmin(at)pse-consulting(dot)de>
Cc: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Server instrumentation patch
Date: 2005-06-24 15:47:52
Message-ID: 02f201c578d4$14f4baf0$0f01a8c0@zaphod
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andreas Pflug wrote:

>>For the second, please supply a patch that moves _all_ of dbsize into
>>the main server. I think we have agreement on that.
>>
>
> I don't think so. As I mentioned, those views are broken. Do you want them
> to be in core anyway?

Why is e.g. this one broken:
int8 database_size(name) - Return the size of the database in
bytes (by name)

It should do the same as the one with the oid except that it will resolve
the name first, no? If not it should be fixed, not dropped. I understand
you'd like to have those functions for the GUI frontends, but what about
psql users? For many people it will be hard work to type the subquery to get
the database oid.

I vote for all (possibly corrected) functions to be moved into core.

Best Regards,
Michael Paesold

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-06-24 15:53:53 Re: [PATCHES] Function's LEAST, GREATEST and DECODE (Oracle vararg polymorphic functions)
Previous Message Mark Cave-Ayland 2005-06-24 15:42:19 Re: Fixing r-tree semantics