| From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Small issues in syncrep.c |
| Date: | 2016-08-09 08:34:53 |
| Message-ID: | 02da4df2-0e47-aa83-cc65-271583ed3cbe@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
Since 14e8803f1, it's not necessary to acquire the SyncRepLock to see up
to date data. But it looks like this commit didn't update all the
comment around MyProc->syncRepState, which still mention retrieving the
value without and without lock. Also, there's I think a now unneeded
test to try to retrieve again syncRepState.
Patch attached to fix both small issues, present since 9.5.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
| Attachment | Content-Type | Size |
|---|---|---|
| fix_syncrep.diff | text/plain | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2016-08-09 08:50:03 | Re: Slowness of extended protocol |
| Previous Message | Michael Paquier | 2016-08-09 08:18:42 | Re: Logical Replication WIP |