| From: | vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Vinayak Pokale <vinpokale(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> |
| Subject: | Re: Transactions involving multiple postgres foreign servers |
| Date: | 2017-03-02 02:56:23 |
| Message-ID: | 02ab0cf3-e154-158e-3127-1b58804411bc@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/02/28 16:54, Masahiko Sawada wrote:
>> I've created a wiki page[1] describing about the design and
>> functionality of this feature. Also it has some examples of use case,
>> so this page would be helpful for even testing. Please refer it if
>> you're interested in testing this feature.
>>
>> [1] 2PC on FDW
>> <https://wiki.postgresql.org/wiki/2PC_on_FDW>
Thank you for creating the wiki page.
In the "src/test/regress/pg_regress.c" file
- * xacts. (Note: to reduce the probability of
unexpected shmmax
- * failures, don't set max_prepared_transactions any
higher than
- * actually needed by the prepared_xacts regression test.)
+ * xacts. We also set *max_fdw_transctions* to enable
testing of atomic
+ * foreign transactions. (Note: to reduce the
probability of unexpected
+ * shmmax failures, don't set max_prepared_transactions or
+ * max_prepared_foreign_transactions any higher than
actually needed by the
+ * corresponding regression tests.).
I think we are not setting the "*max_fdw_transctions" *anywhere.
Is this correct?
In the "src/bin/pg_waldump/rmgrdesc.c" file following header file used
two times.
+ #include "access/fdw_xact.h"
I think we need to remove one line.
Regards,
Vinayak Pokale
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-03-02 03:05:34 | Re: multivariate statistics (v24) |
| Previous Message | Kyotaro HORIGUCHI | 2017-03-02 02:38:32 | Re: IF (NOT) EXISTS in psql-completion |