Re: LEFT JOIN used in psql describe.c

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: LEFT JOIN used in psql describe.c
Date: 2005-04-02 04:17:06
Message-ID: 02a448f61251c43d8a419cd447f2ca95@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Does anyone know why so many LEFT JOINs are used in psql/describe.c to
> join to the pg_namespace table, like here:
>
> I thought a pg_class row always pointed to a valid pg_namespace row
> because of our dependency restrictions.

Yes, pg_relnamespace is definitely not null. I've actually already removed
the left joins from my \df patch, since I had to rewrite some of the
queries anyway. If this is wrong, please let me know of course!

The patch has actually been done for some time now, but the tab completion
part of it got tricky with things like \df <tab> and \dfS <tab>, since the
code pretty much assumes that the only differentiation of system/non-system
objects occurs in pg_class objects. I'll try to get back to it next week,
once DBD::Pg 1.41 is finished up.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200504012315
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFCThy7vJuQZxSWSsgRAuNRAKClDG8QDxnX7LJMWqODtGqKnClpQQCfaZZ8
UwEpCmHJOyfSOuF0MAkQ7xg=
=blNw
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2005-04-02 04:43:25 Re: [HACKERS] plPHP in core?
Previous Message Tom Lane 2005-04-02 04:02:36 Re: Debugging deadlocks