| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove some code for old unsupported versions of MSVC |
| Date: | 2019-10-08 08:55:01 |
| Message-ID: | 024a70dd-107b-dde1-4aaf-01d8e1dcb88f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-10-07 08:52, Michael Paquier wrote:
> On Fri, Oct 04, 2019 at 04:35:59PM +0200, Peter Eisentraut wrote:
>> As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013,
>> which means _MSC_VER >= 1800. This means that conditionals about
>> older versions of _MSC_VER can be removed or simplified.
>>
>> Previous code was also in some cases handling MinGW, where _MSC_VER is
>> not defined at all, incorrectly, such as in pg_ctl.c and win32_port.h,
>> leading to some compiler warnings. This should now be handled better.
>
> Thanks Peter for cleaning up this code. I have looked at it, did some
> testing and it looks good to me. No spots are visibly missing.
pushed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-10-08 09:15:05 | Re: dropping column prevented due to inherited index |
| Previous Message | Amit Langote | 2019-10-08 08:42:36 | Re: dropping column prevented due to inherited index |