| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: bulk typos |
| Date: | 2020-10-25 21:00:33 |
| Message-ID: | 01de8ba3-7cce-af94-536b-dec3da7c9cdf@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25/10/2020 21:48, Justin Pryzby wrote:
> On Sat, Mar 31, 2018 at 05:56:40AM -0500, Justin Pryzby wrote:
>> I needed another distraction so bulk-checked for typos, limited to comments in
>> *.[ch].
>>
>> I'm not passionate about this, but it serves the purpose of reducing the
>> overhead of fixing them individually.
>
> I happened across this old patch, so ran this again to find new typos.
Nice script.
> There's a few that I don't know how best to fix.
>
> Heikki, do you remember what this means ?
> +++ b/src/backend/catalog/storage.c
> + * NOTE: the list is kept in TopMemoryContext to be sure it won't disappear
> + * unbetimes. It'd probably be OK to keep it in TopTransactionContext,
> + * but I'm being paranoid.
Heh, even though I was the last one to touch that line according to git
blame, I just moved it from smgr.c. Looks like Tom wrote it in 2004. I
guess it means "too early". That would make sense from the context.
Google only gives a few hits but they seem to agree with "too early". A
very rare word, for sure. Might be good to change it to "too early", but
it's not wrong, and the poet in me kind of likes "unbetimes" :-).
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-10-25 21:03:21 | Re: Supporting = operator in gin/gist_trgm_ops |
| Previous Message | Justin Pryzby | 2020-10-25 19:48:49 | Re: bulk typos |