| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Bug in error reporting for multi-line JSON |
| Date: | 2021-03-01 14:04:40 |
| Message-ID: | 01F48B70-5CAA-4922-B900-80E49A2D8488@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On 27 Feb 2021, at 22:19, Hamid Akhtar <hamid(dot)akhtar(at)gmail(dot)com> wrote:
> This thread has been inactive for more than a month now.
>
> So, I have reworked Simon's patch and incorporated Tom's feedback. The changes include:
> - Changing the variable name from "pos_last_linefeed" to "last_linestart" as it now points to the character after the newline character,
> - The "for" loop in report_json_context function has been significantly simplified and uses a while loop.
>
> The attached patch is created against the current master branch.
The updated version address the review comments, and pass all tests with no
documentation updates required. Playing around with I was also unable to break
it.
I'm changing the status of this patch to Ready for Committer.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-01 14:36:26 | Re: After upgrade from 9.4.1-3 to 10.15 and fresh install of 10.15 have some differences in the schema definition |
| Previous Message | PG Bug reporting form | 2021-03-01 12:15:41 | BUG #16907: Performance issue after big table drop and recreate |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alejandro Sánchez | 2021-03-01 14:20:31 | Improvements in prepared statements |
| Previous Message | Juan José Santamaría Flecha | 2021-03-01 13:58:35 | Re: [PATCH] Bug fix in initdb output |