| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication worker and statistics |
| Date: | 2017-04-14 18:38:21 |
| Message-ID: | 016aba9e-1171-247c-8e51-c8228b6ae27f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/14/17 12:09, Petr Jelinek wrote:
> Indeed, if catchup phase didn't happen (because tablesync was faster
> than apply) then the commit handler is never called so all the changes
> made by copy would be forgotten. Also the tablesync worker might exit
> from process_syncing_tables() call which is called before we report
> stats in the commit handler so again some changes might be forgotten.
>
> I attached modified version of the patch that also reports stats in
> finish_sync_worker() when there is outstanding transaction. The test can
> stay the same.
committed (without the tests)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-04-14 18:45:28 | Re: [HACKERS] Small issue in online devel documentation build |
| Previous Message | Petr Jelinek | 2017-04-14 18:23:17 | Re: logical replication and PANIC during shutdown checkpoint in publisher |