Re: pg_regress breaks on msys

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress breaks on msys
Date: 2006-07-20 15:24:01
Message-ID: 016201c6ac10$87843300$01324d80@hiroshi5jz7dqj
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

From: "Tom Lane"

> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> > This is very strange.!!
> > boolean ... ok
> > char ... diff command failed with status 1: "diff -w "./expected/char.out"
> > "./results/char.out" >"./results/char.diff""
> > server stopped
>
> Yes, I believe the problem is that our Windows versions of the
> WIFEXITED/WEXITSTATUS macros are wrong. pg_regress is trying to verify
> that the diff call didn't fail entirely (eg, diff not there or failed
> to read one of the files), but the status code diff is returning for
> "files not the same" is confusing it.

Probably No, I also suspected it in the beginning. However, char.diff was not created
by some strange condition. I think that WIFEXITED showed the strange condition.
In the place which I showed above, diff makes char.diff from the Manual operation.
I expect that it is related to a system() call.

I am investigating in some other environments. now...
However, It does not clarify yet..:-(

Regards,
Hiroshi Saito

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Luke Lonergan 2006-07-20 15:36:55 Re: Progress bar updates
Previous Message Tom Lane 2006-07-20 14:54:44 Re: float8 regression failure (HEAD, cygwin)

Browse pgsql-patches by date

  From Date Subject
Next Message Joachim Wieland 2006-07-20 17:28:44 Re: modular pg_regress.sh
Previous Message Tom Lane 2006-07-20 14:54:44 Re: float8 regression failure (HEAD, cygwin)