Re: ssl passphrase callback

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ssl passphrase callback
Date: 2019-11-15 13:59:45
Message-ID: 015207a5-1e4c-c187-960c-2f7bb5627d7e@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11/14/19 3:21 PM, Alvaro Herrera wrote:
> On 2019-Nov-14, Andrew Dunstan wrote:
>
>> I guess this would work. There would have to be a deal of code to load
>> the library and lookup the symbol. Do we really think it's worth it?
>> Leveraging shared_preload_libraries makes this comparatively simple.
> Using the generic interface has the drawback that the user can make more
> mistakes. I think that's part of Bruce's issue with it (although I may
> misinterpret.)
>
> I think if you add most of it as a new entry point in dfmgr.c (where you
> can leverage internal_library_load) and returns a function pointer to
> the user specified function, it's all that much additional code.
>
> (I don't think you can use load_external_function as is, because it
> assumes fmgr V1 calling convention, which I'm not sure serves your case.
> But then maybe it does. And if not, then those 10 lines should be very
> similar to the code you'd need to add.)

In the absence of further comment I will try to code up something along
these lines.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2019-11-15 14:52:04 Re: SimpleLruTruncate() mutual exclusion
Previous Message Sergei Kornilov 2019-11-15 13:52:27 Re: base backup client as auxiliary backend process