Re: display and expression of the home directory in Win32

From: "Hiroshi Saito" <saito(at)inetrt(dot)skcapi(dot)co(dot)jp>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: display and expression of the home directory in Win32
Date: 2006-01-06 18:38:38
Message-ID: 012701c612f0$6c3c4ce0$0b01a8c0@yourc3ftrhkaod
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

From: "Magnus Hagander"

>> HOMEDIR = "C:/Documents and Settings/saito/Application
>> Data/postgresql"
>> VERSION = PostgreSQL 8.1.1
>
> HOMEDIR is a very bad name for this variable, since it's *not* the home
> directory. It could easily be confused. If we put it in, I definitly
> think it should be called something else.. (USERCONFDIR based on that we

Um, About a name, I think that it is right.

> have SYSCONFDIR, perhaps?). Also, there is no reason not to include it
> on Unix as well - it would actrually be much better to do that, in case
> someone wants to write a script that relies on it.

It will be good to be clearly shown in all environments.

>> dir "C:/Documents and Settings/saito/Application Data/postgresql"
>
> This would then be:
> dir "%APPDATA%\postgresql"
>
> which is actually much easier to use than getting it from pg_config,
> since you can use the environment variable in any command you want.

Probably, there is a user who notices after the directory is shown.

Regards,
Hiroshi Saito

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruno Wolff III 2006-01-06 18:42:09 Re: [HACKERS] Inconsistent syntax in GRANT
Previous Message Tom Lane 2006-01-06 18:01:37 Re: [HACKERS] Inconsistent syntax in GRANT