Re: 7.3 -> pg_atoi: zero-length string

From: "Ben-Nes Michael" <miki(at)canaan(dot)co(dot)il>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Lee Kindness" <lkindness(at)csl(dot)co(dot)uk>
Cc: "postgresql" <pgsql-general(at)postgresql(dot)org>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 7.3 -> pg_atoi: zero-length string
Date: 2002-12-03 16:14:34
Message-ID: 011801c29ae7$11d0ba90$aa0f5ac2@canaan.co.il
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Then Why not set it to NULL

Seems logic as there is nothing between ''

What is the solution of other dbs ( oracle, db2 .. ) to:
insert into table (num) value (''); ?

Who knows how many application will suffer becouse of this.

----- Original Message -----
From: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Lee Kindness" <lkindness(at)csl(dot)co(dot)uk>
Cc: "Ben-Nes Michael" <miki(at)canaan(dot)co(dot)il>; "postgresql"
<pgsql-general(at)postgresql(dot)org>; <pgsql-hackers(at)postgresql(dot)org>
Sent: Tuesday, December 03, 2002 6:08 PM
Subject: Re: [GENERAL] 7.3 -> pg_atoi: zero-length string

>
> The change was made to tighten up the code to catch errors sooner.
> There isn't much logic to making '' be 0, and no one could make a case
> for keeping such a mapping.
>
> --------------------------------------------------------------------------
-
>
> Lee Kindness wrote:
> > Was it necessary? No idea, you're welcome to search through the
> > pgsql-hackers archives to determine the reasoning behind the change. I
> > believe the change was made by Bruce Momjian (going by the release
> > notes). I only remember reading the discussion in passing.
> >
> > This is also one of the reasons for beta releases - to allow people to
> > test against the new version and pick up these sort of things. Either
> > this gives them/you time to make changes, or to lobby to get the old
> > behaviour back.
> >
> > If I were in your situation i'd probably hack back the old behaviour
> > to 7.3, compile and run that while changes were made. Or stick with
> > 7.2.x until changes were made to your applications, have you got a
> > 'big carrot' for going with 7.3?
> >
> > Lee.
> >
> > Ben-Nes Michael writes:
> > > That's indeed very nice but I don't see the logic in it.
> > >
> > > If I want to upgrade I need to go on all my projects and change
thousands of
> > > lines.
> > >
> > > And that's not all :(
> > > I have other applications like phprojekt that was not developed by me
and
> > > became useless now as I cant insert.
> > >
> > > Was this step so necessary ?
> > >
> > > ----- Original Message -----
> > > From: "Lee Kindness" <lkindness(at)csl(dot)co(dot)uk>
> > > To: "Ben-Nes Michael" <miki(at)canaan(dot)co(dot)il>
> > > Cc: "postgresql" <pgsql-general(at)postgresql(dot)org>; "Lee Kindness"
> > > <lkindness(at)csl(dot)co(dot)uk>
> > > Sent: Tuesday, December 03, 2002 12:37 PM
> > > Subject: [GENERAL] 7.3 -> pg_atoi: zero-length string
> > >
> > > > Hi, one of the changes in 7.3 was to disallow '' being implicitly
> > > > converted to 0. In your example below image_order is clearly not a
> > > > text/char column, so what are you trying to set it too? If you want
it
> > > > be 0 then explicitly use 0, if you want it to be undefined then use
> > > > NULL.
> > > >
> > > > Lee.
> > > >
> > > > Ben-Nes Michael writes:
> > > > > Hi
> > > > >
> > > > > After I upgraded 7.2.3 to 7.3 I started to get the following
errors:
> > > > > pg_atoi: zero-length string
> > > > >
> > > > > its seems that i get it when not all field have content:
> > > > >
> > > > > this is one example that generate the error:
> > > > > insert into images (section_id, pic_date, image_order) values
('8',
> > > > > '2002-12-03', '')
> >
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square, Pennsylvania
19073
>

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bruce Momjian 2002-12-03 16:21:04 Re: 7.3 -> pg_atoi: zero-length string
Previous Message Bruce Momjian 2002-12-03 16:08:50 Re: 7.3 -> pg_atoi: zero-length string

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Naeslund(f) 2002-12-03 16:15:53 Re: Backend crash with tsearch
Previous Message Magnus Naeslund(f) 2002-12-03 16:12:31 Re: Backend crash with tsearch