| From: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "'Alvaro Herrera'" <alvherre(at)2ndquadrant(dot)com> |
| Cc: | "'Dimitri Fontaine'" <dimitri(at)2ndQuadrant(dot)fr>, "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Fujii Masao'" <masao(dot)fujii(at)gmail(dot)com>, <cedric(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com>, "'Greg Smith'" <greg(at)2ndquadrant(dot)com>, "'Josh Berkus'" <josh(at)agliodbs(dot)com>, "'Magnus Hagander'" <magnus(at)hagander(dot)net>, "'Christopher Browne'" <cbbrowne(at)gmail(dot)com> |
| Subject: | Re: Proposal for Allow postgresql.conf values to be changed via SQL |
| Date: | 2012-11-19 15:36:58 |
| Message-ID: | 00e101cdc66b$b760d7f0$262287d0$@kapila@huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, November 19, 2012 8:36 PM Alvaro Herrera wrote:
> Amit Kapila escribió:
>
> > The only point I can see against SET PERSISTENT is that other variants
> of
> > SET command can be used in
> > transaction blocks means for them ROLLBACK TO SAVEPOINT functionality
> works,
> > but for SET PERSISTENT,
> > it can't be done.
> > So to handle that might be we need to mention this point in User
> Manual, so
> > that users can be aware of this usage.
> > If that is okay, then I think SET PERSISTENT is good to go.
>
> I think that's okay. There are other commands which have some forms
> that can run inside a transaction block and others not. CLUSTER is
> one example (maybe the only one? Not sure).
In that case, it can have one more advantage that all configuration setting
can be done with one command
and in future we might want to have option like BOTH where the command will
take effect for memory as well
as file.
Can you think of any strong reason why not to have with Alter System
Command?
In any case SET PERSISTENT is fine.
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2012-11-19 15:39:27 | Re: ALTER command reworks |
| Previous Message | Amit kapila | 2012-11-19 15:29:49 | Re: [WIP PATCH] for Performance Improvement in Buffer Management |