Re: Show lossy heap block info in EXPLAIN ANALYZE for bitmap heap scan

From: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: "'Etsuro Fujita'" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com>
Cc: "'Amit Khandekar'" <amit(dot)khandekar(at)enterprisedb(dot)com>, "'pgsql-hackers'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Show lossy heap block info in EXPLAIN ANALYZE for bitmap heap scan
Date: 2014-01-10 03:57:02
Message-ID: 00a901cf0db8$04e2a6e0$0ea7f4a0$@etsuro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Robert Haas wrote:
> > Hmm, fair point. But I'm still not convinced that we really need to
> > add extra accounting for this. What's wrong with just reporting the
> > number of exact and lossy pages?

> No. I intended to show the desired memory space for a TIDBitmap rather
> than the peak memory usage for that TIDBitmap. And I thought it'd be
better
> for the latter to be displayed as additional information. However, I've
> removed the functionality for showing the desired memory space due to
> technical problems. Now I should probably remove the functionality for
> showing the peak memory usage too.

> Yes, as Andres mentioned, showing the peak memory usage is not a bad idea,
> I think. But I start to think it's not necessarily worth complicating the
> code ...

> If there are no objections of others, I'll remove extra accounting for
> showing the peak memory usage.

Done. Please find attached a patch.

Thanks,

Best regards,
Etsuro Fujita

Attachment Content-Type Size
explain-bitmapscan-20140110.patch application/octet-stream 4.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-01-10 04:06:38 Re: ALTER SYSTEM SET command to change postgresql.conf parameters
Previous Message Peter Geoghegan 2014-01-10 03:36:24 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE