Re: Solve a problem of LC_TIME of windows.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Solve a problem of LC_TIME of windows.
Date: 2008-09-24 14:55:10
Message-ID: 00a101c91e55$8ad86260$0b01a8c0@IBMC9A0F63B40D
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi.

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> In principle, I think this patch looks good.
>
> Do you (or somebody else) have an example where this breaks in an
> encoding where I can actually understand the characters, though ;-) That
> would make testing a whole lot easier...
>
> Also, the patch needs error checking. strftime() can fail, and the
> multibyte conversion functions can certainly fail. That will need to be
> added.

Ok, thanks!

strftime return to 0.
http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx
MultiByteToWideChar and WideCharToMultiByte return to GetLastError.
http://msdn.microsoft.com/en-us/library/ms776413(VS.85).aspx

I will proposal the next patch.:-)

BTW, this is SQL for a check.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/DATECHECK.sql
Probably, all are included.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/LC_TIME_PATCH/LC_TIME_CHECK_LOCALE.sql

Regards,
Hiroshi Saito

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Saito 2008-09-24 14:55:18 Re: Solve a problem of LC_TIME of windows.
Previous Message Heikki Linnakangas 2008-09-24 14:42:37 Re: Initial prefetch performance testing

Browse pgsql-patches by date

  From Date Subject
Next Message Hiroshi Saito 2008-09-24 14:55:18 Re: Solve a problem of LC_TIME of windows.
Previous Message Alvaro Herrera 2008-09-24 14:15:19 Re: Solve a problem of LC_TIME of windows.