From: | "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> |
---|---|
To: | <pgsql-hackers(at)postgresql(dot)org>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: 7.3 and HEAD broken for dropped columns of dropped types |
Date: | 2003-05-12 01:59:08 |
Message-ID: | 009501c3182a$177013e0$6500a8c0@fhp.internal |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I am thinking that it might be a good idea for ALTER TABLE DROP COLUMN
> to reset atttypid to zero in the dropped column's pg_attribute row.
> This would help catch any other places that are depending on a dropped
> column's atttypid to still be valid. On the other hand, it would
> possibly confuse applications that are looking at pg_attribute.
> Comments anyone?
I think you should zero it - we keep finding these little places where we've
missed thinking about dropped columns and that should flush them out. Any
application looking at the type of a dropped column is confused anyway...
(Or they're doing a join...which could result in the dropped column not
appearing in their result set but hey...)
Chris
From | Date | Subject | |
---|---|---|---|
Next Message | alex avriette | 2003-05-12 02:55:46 | patch src/bin/psql/help.c |
Previous Message | Andrew Dunstan | 2003-05-12 00:25:09 | Re: Plans for index names unique to a table? |