Re: Minor inheritance/check bug: Inconsistent behavior

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Bruce Momjian'" <bruce(at)momjian(dot)us>
Cc: <robertmhaas(at)gmail(dot)com>, <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor inheritance/check bug: Inconsistent behavior
Date: 2013-01-26 06:01:49
Message-ID: 008701cdfb8a$a1eaf140$e5c0d3c0$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, January 25, 2013 8:36 PM Bruce Momjian wrote:
> On Fri, Sep 14, 2012 at 02:04:51PM +0000, Amit kapila wrote:
> > On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote:
> >
> > On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila
> <amit(dot)kapila(at)huawei(dot)
> > com> wrote:
> > >> AFAICT during Update also, it doesn't contain useful. The only
> chance it
> > >> would have contain something useful is when it goes for
> EvalPlanQual and
> > >> then again comes to check for constraints. However these
> attributes get
> > >> filled in heap_update much later.
> > >
> > >> So now should the fix be that it returns an error for system
> column
> > >> reference except for OID case?
> >
> > > +1.
> >
> >
> >
> > 1. I think in this scenario the error for system column except for
> tableOID
> > should be thrown at Create/Alter time.
> >
> > 2. After setting OID in ExecInsert/ExecUpdate may be setting of same
> inside
> > heap functions can be removed.
> >
> > But for now I have kept them as it is.
> >
> >
> >
> > Please find the Patch for bug-fix.
> >
> > If this is okay, I shall send you the test cases for same.
>
> Did we ever make any progress on this?

I have done the initial analysis and prepared a patch, don't know if
anything more I can do until
someone can give any suggestions to further proceed on this bug.

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2013-01-26 07:39:58 Re: Visual Studio 2012 RC
Previous Message Craig Ringer 2013-01-26 05:38:18 Re: Visual Studio 2012 RC