Always the same ecpg bug - please (re)apply patch

From: "Nicolas Bazin" <nbazin(at)ingenico(dot)com(dot)au>
To: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Michael Meskes" <meskes(at)postgresql(dot)org>
Subject: Always the same ecpg bug - please (re)apply patch
Date: 2002-03-27 23:30:21
Message-ID: 007001c1d5e7$5cae1a00$660d090a@software.ingenico.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is the description:

When a macro is replaced by the preprocessor, pgc.l reaches a end of file, which is not the actual end of the file. One side effect of that is that if you are in a ifdef block, you get a wrong error telling you that a endif is missing.

This patch corrects pgc.l and also adds a test of this problem to test1.pgc. To convince you apply the patch to test1.pgc first then try to compile the test then apply the patch to pgc.l.

The patch moves the test of the scope of an ifdef block to the end of the file beeing parsed, including all includes files, ... .

For the record, this patch was applied a first time by bruce then overwritten by Micheal and reapplied by him. But the big mystery is that there is no trace of that in CVS ????

Nicolas

Attachment Content-Type Size
ecpg.patch application/octet-stream 4.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2002-03-27 23:53:53 Re: compile bug in HEAD?
Previous Message Nicolas Bazin 2002-03-27 22:34:53 Re: build of 7.2.1 on SCO Openserver and Unixware 7.1.1