| From: | "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "'Etsuro Fujita'" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, "'Kyotaro HORIGUCHI'" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org>, <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Get more from indices. |
| Date: | 2013-11-28 03:50:07 |
| Message-ID: | 005301ceebec$edcdf4b0$c969de10$@etsuro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Kyotaro HORIGUCHI wrote:
> > > * In get_relation_info(), the patch determines the branch condition
> > > "keyattno != ObjectIdAttributeNumber". I fail to understand the
> > > meaning of this branch condition. Could you explain about it?
> > Literally answering, it means oid cannot be NULL (if it exists).
> Understood. Thank you for the detailed information. But I'm not sure
it's
> worth complicating the code. What use cases are you thinking?
Having said that, I've reconsidered about this, and start to think it would
be better that all system attributes are processed in the same way as are
user attributes because that makes the code more simple. Yes, as you
mention, it's not necessarily guaranteed that system attributes have the
uniqueness property in general, but that's another problem.
Thanks,
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2013-11-28 05:06:50 | Re: TODO: Split out pg_resetxlog output into pre- and post-sections |
| Previous Message | Peter Eisentraut | 2013-11-28 02:54:48 | Re: Put json type into alphabetical order in manual table |