Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Alvaro Herrera'" <alvherre(at)2ndquadrant(dot)com>, "'Greg Smith'" <greg(at)2ndQuadrant(dot)com>
Cc: "'Robert Haas'" <robertmhaas(at)gmail(dot)com>, "'Greg Stark'" <stark(at)mit(dot)edu>, "'Andres Freund'" <andres(at)2ndquadrant(dot)com>, "'Boszormenyi Zoltan'" <zb(at)cybertec(dot)at>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Date: 2013-03-22 02:39:20
Message-ID: 005101ce26a6$75c34080$6149c180$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, March 22, 2013 12:48 AM Alvaro Herrera wrote:
> Greg Smith escribió:
> > On 3/21/13 2:38 PM, Robert Haas wrote:
> > >Also, while I think that MOST people will probably want a SIGHUP
> right
> > >after SET PERSISTENT, I am not sure that EVERYONE will want that.
> If
> > >you want it and it doesn't happen automatically, you can always do
> it
> > >by hand.
> >
> > This is a fair position, and since that's how the feature as written
> > right now works that helps. I think proceeding this way needs to
> > hand some sort of hint back to the user though, telling them the
> > change isn't active until SIGHUP. The path I don't want to see if
> > where someone uses SET PERSISTENT and can't figure out why nothing
> > changed. It should be as obvious as we can make it to someone that
> > the explicit reload is necessary.
>
> Maybe add some syntax to prevent the SIGHUP for the rare case where
> that
> is wanted, say
>
> SET PERSISTENT (reload=off) var=val;
>
> (perhaps WITH at the end, dunno)

I think adding new syntax change is little scary for me, not for the matter
of implementation but for building consensus on syntax.
Can we do it as an enhancement later?
Other ways could be to either give Notice after each command or mention the
same in documentation clearly.
I feel giving Notice after every command doesn't look good, so may be we can
mention the same in documentation.

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-03-22 03:27:23 Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Previous Message Tom Lane 2013-03-22 02:14:53 Re: Should commit_delay be PGC_SIGHUP?