From: | "Michael Paesold" <mpaesold(at)gmx(dot)at> |
---|---|
To: | "Neil Conway" <neilc(at)samurai(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "Joachim Wieland" <joe(at)mcknight(dot)de>, <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: TODO item: list prepared queries |
Date: | 2005-12-14 07:40:16 |
Message-ID: | 004c01c60081$b67b1a60$0f01a8c0@zaphod |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
>> One minor irritation is that the query string of prepared statements
>> created via SQL has "PREPARE ... AS" prefixed to it, whereas statements
>> prepared via the FE-BE protocol do not. This should probably be fixed,
>> but I can't see a clean way to do it: I think we'd need to munge the
>> actual SQL string itself and remove the "PREPARE ..." prefix. Thoughts?
>
> BTW, pursuant to comments about David's proposal just now --- why is the
> patch using text at all, rather than reverse-compiling the prepared
> statement's querytree?
Well, I think for the driver or application, to recognize queries as their
own, it seems much easier if the query is given exaclty as it was sent. I.e.
even including PREPARE -- if it sent this way. I am not sure of the latter,
but I would prefer to be given the original query string, PREPARE stripped
or not.
This comment is based on my assumption -- hopefully correct -- that the
querytree has indeed changed from the original query. E.g. removed redundant
parenthesis, added casts, etc.
Best Regards,
Michael Paesold
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-12-14 15:58:00 | Re: TODO item: list prepared queries |
Previous Message | Tom Lane | 2005-12-14 04:35:57 | Re: TODO item: list prepared queries |