| From: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "'Heikki Linnakangas'" <hlinnakangas(at)vmware(dot)com> |
| Cc: | "'Phil Sorber'" <phil(at)omniti(dot)com>, "'Alvaro Herrera'" <alvherre(at)2ndquadrant(dot)com>, "'Magnus Hagander'" <magnus(at)hagander(dot)net>, "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq |
| Date: | 2013-02-26 07:06:24 |
| Message-ID: | 004601ce13ef$ca72b670$5f582350$@kapila@huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote:
> On 21.02.2013 16:09, Amit Kapila wrote:
> > On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote:
> I've committed those patches, with some further changes. If you have
> the
> time, please take another look at the committed patches. Thanks!
1. For pg_dumpall, incase user gives dbname in connection string, for ex.
"user=amit dbname=db_regress port=5434"
it will be ignored and postgres (default database name) will be used.
2. For pg_basebackup, no need to check if(conn_opts) before PQconninfoFree
as it will internally take care of
NULL. This will not cause any harm, just an observation.
With Regards,
Amit Kapila
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-02-26 07:48:09 | Re: Floating point error |
| Previous Message | Kyotaro HORIGUCHI | 2013-02-26 06:52:04 | Re: 9.2.3 crashes during archive recovery |