From: | "Michael Paesold" <mpaesold(at)gmx(dot)at> |
---|---|
To: | "Michael Paesold" <mpaesold(at)gmx(dot)at>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fix for VACUUM in psql autocommit off |
Date: | 2004-09-20 07:54:44 |
Message-ID: | 003a01c49ee7$18f1f2c0$ad01a8c0@zaphod |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Michael Paesold wrote
> Tom Lane wrote:
> > Per SQL spec, the backend thinks that /* .. */ nests:
> >
> > regression=# /* some /* comment */ comment */ select 1;
> > ?column?
> > ----------
> > 1
> > (1 row)
> >
> > As it stands, is_transact_command will get confused by this.
It is now fixed in the attached patch.
> > I'd split out the code that locates "the next keyword" into a separate
> > function that could be called twice.
>
> I have read this mail after making the attached patch, so I have used a
> little different approach. I have moved the code to skip over whitespace
and
> comments into it's own function.
Well, reading this again after some sleep, we probably meant the same.
Concerning my other patch that also touches psql/common.c (Rollback of only
last statement), have you looked into it?
Best Regards,
Michael Paesold
Attachment | Content-Type | Size |
---|---|---|
psql-autocommit.diff | application/octet-stream | 3.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2004-09-20 07:57:48 | Re: Update zh_TW message files |
Previous Message | Peter Eisentraut | 2004-09-20 07:51:34 | Re: Yet another pair of spanish translation updates |