From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
---|---|
To: | rir <rirans(at)comcast(dot)net> |
Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: small patch |
Date: | 2021-10-11 06:57:08 |
Message-ID: | 00307b02220a8018baee6b35180a3e2bc4abecb2.camel@cybertec.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Sun, 2021-10-10 at 16:15 -0400, rir wrote:
> On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
>
>
> > So I suggest that you change the syntax diagram to
> >
> > FETCH [ direction ] [ FROM | IN ] cursor_name
>
> > Then I agree that the "empty or" can be removed.
>
> > I remain of the opinion that the comments should be
> > retained, but we can leave that for somebody else to
> > decide.
>
> I accept your three points above.
>
> The MOVE synopsis shows the same parsing as I presented,
> should it be changed in the same way (move a square bracket left to
> be after <direction>)? My guess is yes, but I've never used an
> SQL cursor.
>
> When this convo settles, I send a new patch. Probably
> here in the group. If I have a few more, or a complex one,
> I'll check out the other submission method.
Yes, I think that such a patch would meet with favor.
Make sure to register it on the commitfest. To do that, it is better
to send the patch to the -hackers list. The commitfest application
won't find conversations on the -docs list.
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | PG Doc comments form | 2021-10-11 07:03:31 | Remove unary operator documentation https://www.postgresql.org/docs/current/datatype-oid.html |
Previous Message | rir | 2021-10-10 20:15:01 | Re: small patch |