Re: Fixes for compiler warnings

On Jan 17, 2009 3:34pm, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Saturday 17 January 2009 11:44:07 Alan Li wrote:
>
> > Attached are patches to fix the following compiler warnings that I see
when
>
> > using gcc 4.3.2.
>
> >
>
> > MASTER warning:
>
> > tablecmds.c: In function 'DropErrorMsgWrongType':
>
> > tablecmds.c:601: warning: format not a string literal and no format
>
> > arguments
>
> >
>
> > REL8_3_STABLE warnings:
>
> > utility.c: In function 'DropErrorMsgWrongType':
>
> > utility.c:129: warning: format not a string literal and no format
arguments
>
> > trigger.c: In function 'ConvertTriggerToFK':
>
> > trigger.c:600: warning: format not a string literal and no format
arguments
>
> > trigger.c:616: warning: format not a string literal and no format
arguments
>
> > trigger.c:628: warning: format not a string literal and no format
arguments
>
> > guc.c: In function 'set_config_option':
>
> > guc.c:4424: warning: format not a string literal and no format arguments
>
> > describe.c: In function 'describeOneTableDetails':
>
> > describe.c:1294: warning: format not a string literal and no format
>
> > arguments
>
>
>
> You apparently have your compiler configured with -Wformat-security. Our
code
>
> doesn't do that. I think the cases the warning complains about are fine
and
>
> the way the warning is designed is a bit bogus.
>

Yeah, you're right. I'm using gcc 4.3.2 on Ubuntu 8.10, which uses
-Wformat-security by default.

Alan