RE: RE: [PATCHES] relation filename patch

From: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
To: "Ross J(dot) Reedstrom" <reedstrm(at)wallace(dot)ece(dot)rice(dot)edu>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgman(at)candle(dot)pha(dot)pa(dot)us>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: RE: [PATCHES] relation filename patch
Date: 2000-05-02 01:09:47
Message-ID: 000b01bfb3d3$1b93b6c0$2801007e@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> -----Original Message-----
> From: Ross J. Reedstrom [mailto:reedstrm(at)wallace(dot)ece(dot)rice(dot)edu]
> >
> > I didn't see what you did here, but I doubt that it was the right thing.
>
> Probably not: this is my first extensive digging into the backend code.
> And the whole reason this is a 'lets try and implement somne of this,
> and go back to the discussion' patch, instead of a proposed addition.
>
> In defense of what I _did_: The temp table relname hacking is still
> in place, and seems to work, and could be left in place.

Yes,pararell regression tests all pass here if relacache hashes
on pg_class entry name.

> However, I
> knew that relname would not stay unique, once schema are implemented,
> but physrelname would (since the smgr needs it).
>

It is dangerous to combine logical and physical concepts.
So it seems difficult to use physrelname both as a storage location
and as an unique relation name.

Regards.

Hiroshi Inoue
Inoue(at)tpf(dot)co(dot)jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Inoue 2000-05-02 01:42:22 RE: When malloc returns zero ...
Previous Message Lamar Owen 2000-05-02 00:59:59 [Fwd: PG 7.0 is great!]