static global variable openLogOff in xlog.c seems no longer used

From: "Takashi Menjo" <menjo(dot)takashi(at)lab(dot)ntt(dot)co(dot)jp>
To: <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: <ishizaki(dot)teruaki(at)lab(dot)ntt(dot)co(dot)jp>
Subject: static global variable openLogOff in xlog.c seems no longer used
Date: 2019-01-29 02:49:37
Message-ID: 000101d4b77d$45fc88c0$d1f59a40$@lab.ntt.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Because of pg_pwrite()[1], openLogOff, a static global variable in xlog.c,
seems taken over by a local variable startoffset and no longer used now.

I write the attached patch that removes openLogOff. Both "make check" and
"make installcheck" passed, and just after that, "pg_ctl -m immediate stop"
then "pg_ctl start" looked OK.

Regards,
Takashi

[1] See commit c24dcd0cfd949bdf245814c4c2b3df828ee7db36.

--
Takashi Menjo - NTT Software Innovation Center
<menjo(dot)takashi(at)lab(dot)ntt(dot)co(dot)jp>

Attachment Content-Type Size
Remove-openLogOff.patch application/octet-stream 2.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-01-29 03:18:29 Re: pg_stat_ssl additions
Previous Message Andreas Karlsson 2019-01-29 02:36:24 Re: Early WIP/PoC for inlining CTEs